feat(wallet): hardware wallet via external signer connector#137
Merged
Conversation
HardwareWallet now extends RailgunWallet and delegates signing to a pluggable ExternalSignerConnector, with an optional batch-approval step that emits a sub-session string forwarded to each per-transaction sign call. AbstractWallet, RailgunWallet typing on TransactionBatch, and ViewOnlyWallet are intentionally left untouched; the hardware wallet stores its own spendingPublicKey reference to avoid leaning on private base-class state. RailgunEngine gains createHardwareWalletFromShareableViewingKey and loadExistingHardwareWallet, mirroring the view-only flow and unloading any conflicting wallet type on the same ID before reattaching the connector.
mesquka
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HardwareWallet now extends RailgunWallet and delegates signing to a pluggable ExternalSignerConnector, with an optional batch-approval step that emits a sub-session string forwarded to each per-transaction sign call. AbstractWallet, RailgunWallet typing on TransactionBatch, and ViewOnlyWallet are intentionally left untouched; the hardware wallet stores its own spendingPublicKey reference to avoid leaning on private base-class state.
RailgunEngine gains createHardwareWalletFromShareableViewingKey and loadExistingHardwareWallet, mirroring the view-only flow and unloading any conflicting wallet type on the same ID before reattaching the connector.