Backport cartographer AIR trade fix to 1.21.1 - #88
Open
idkwhodatis wants to merge 1 commit into
Open
idkwhodatis wants to merge 1 commit into
idkwhodatis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a crash in Visible Traders 1.3.2 on Minecraft 1.21.1 when trading with cartographers.
The crash was caused by unresolved async cartographer trades using an AIR placeholder that could leak into the villager’s normal offers and later fail during NBT saving with Item must not be minecraft:air.
The fix:
tracks async trade completion separately from the returned offer,
prevents unresolved placeholders from entering vanilla villager offers,
unwraps completed futures into normal trades,
safely skips cartographer map trades that resolve to null.
Tested in-game with the previously crashing cartographer trade/save flow.