Feat/squashed 2026 07 06#2847
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…r/subtensor into feat/ck-take-settings-pays-yes
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
eco-tests changed — indexer review requiredThis PR modifies files under Changed files
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE VERY HIGH scrutiny: 8-day-old account with 1 public repo and 2 lifetime PR contributions, tempered by repository write permission and commits predominantly authored by established contributor gztensor; correctly targets devnet-ready and has no known Gittensor association. Static review covered the consensus-critical dust accounting, issuance migration, coinbase liquidity reservoirs, swap cleanup, and runtime configuration changes. No trusted AI-review or Copilot instruction files were modified. FindingsNo findings. Prior-comment reconciliation
ConclusionThe previously missing runtime version bump is now present, and no malicious behavior or security vulnerability remains evident in the patch. 📜 Previous run (superseded)
🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor association UNKNOWN; newly created contributor account with repository write access, so the large integration diff received heightened scrutiny. PR body was empty/trivial; the Auditor has auto-filled it. Please review. The runtime change is accompanied by a This PR subsumes the dust-accounting work in #2754 and adds broader integration coverage. This PR is the better candidate. Recommend closing #2754. Other overlaps are incidental or concern broader active branches rather than equivalent implementations. The devnet endpoint was unavailable in this environment, so its live FindingsNo findings. ConclusionThe integrated changes are internally consistent, appropriately tested, and contain no merge-blocking domain defects in the reviewed diff. |
|
🔄 AI review updated — Skeptic: VULNERABLE |
|
🔄 AI review updated — Skeptic: VULNERABLE |
… restore HotKeyAlreadyRegisteredInSubNet coverage - spec_version 427 -> 428: this PR changes consensus behavior (DustRemoval wiring, new balancer reservoir storage, coinbase injection, Pays::Yes on take extrinsics) but repeated devnet-ready merges neutralized the branch's earlier spec bumps. - test_coinbase_inject_and_maybe_swap_reverts_excess_tao_deposit_on_swap_failure was missing #[test] and never ran (masked by the file's allow(unused)); it passes once enabled. - test_swap_owner_new_hotkey_already_exists had been rewired to assert NonAssociatedColdKey, silently dropping coverage of the already-registered-in-subnet guard; the foreign-coldkey case is now its own test and the original coverage is restored. Co-authored-by: Cursor <cursoragent@cursor.com>
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Motivation
This integration PR consolidates the fixes and features previously collected in #2832, including work from #2753, #2707, #2734, #2736, #2750, #2758, and #2818. It prepares the combined runtime changes for
devnet-readywhile preserving accounting invariants and adding regression coverage.Changes
Files of interest
pallets/subtensor/src/coinbase/pallets/subtensor/src/migrations/pallets/subtensor/src/subnets/dissolution.rspallets/swap/src/pallet/runtime/src/lib.rsruntime/tests/balances_dust.rseco-tests/src/tests_mentat_indexer.rsBehavioral and migration impact
Protocol emissions that cannot immediately become price-active are retained in per-subnet reservoirs and retried later instead of being omitted from accounting. Dust removal now updates Subtensor issuance alongside Balances issuance. Existing one-shot issuance and hotkey-lock repair migrations are extended for the corrected state transitions.
The runtime
spec_versionis bumped from 427 to 428.Testing
The PR adds targeted unit and runtime tests covering dust reaping, order-swap and leasing transfers, failed excess-TAO swaps, liquidity reservoir activation and cleanup, subnet dissolution, migration indexing, delegate fee metadata, hotkey ownership checks, and Mentat/indexer runtime APIs. The source PR reports that formatting, linting, and existing unit tests pass locally.