Beautify the extension UI#2851
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE VERY HIGH account-age/activity scrutiny, mitigated by repository write permission; no Gittensor association found; feat/extension-ui → bittensor-core-exploration. The diff is limited to SDK extension-bridge presentation and transaction-result reporting. It introduces no runtime, dependency, privilege, workflow, or trusted-review-instruction changes. FindingsNo findings. ConclusionNo malicious behavior or security vulnerability was found in the reviewed diff. 🔍 AI Review — Auditor (domain review)VERDICT: 👎 Gittensor association UNKNOWN; the author is a very new GitHub account but has repository write access, so behavior and tests were reviewed without relying on contribution history. PR body was empty/trivial; the Auditor has auto-filled it. Please review. The visual redesign is cohesive, and the transaction-result RPC is wired through the client and signer. However, the redesign removes the browser’s only actionable diagnostics, leaving common setup and connection failures visually unexplained. Findings
ConclusionThe bridge must continue showing actionable error text before this UI-focused PR is ready. No build or runtime execution was necessary to confirm this static regression. |
| listAccounts().catch((error) => { | ||
| setStatus(error.message, "err"); | ||
| setBridgeState("error"); |
There was a problem hiding this comment.
[MEDIUM] Bridge errors no longer tell the user what failed
The previous UI displayed error.message; this handler now only changes the pulse color while the page continues to say “Keep this page open / Switch back to btcli.” Missing extensions, rejected authorization, stale sessions, disconnects, and WebSocket failures therefore become indistinguishable and unactionable. Preserve the new design, but update headlineEl/detailEl with the error text here and provide explicit messages in the stale-session, disconnect, and WebSocket-error handlers below.
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👎 |
Motivation
Improve the browser-extension signing bridge so it presents a polished, focused interface and clearly indicates when a submitted transaction succeeds or fails.
What changed
sdk/python/bittensor/extension/static/bridge.htmlwith a responsive dark interface, connection-state styling, and reduced-motion support.transaction.resultbridge RPC that updates the page after submission.BridgeClient,ExtensionSigner, and the CLI execution flow for both ordinary and MEV-shielded submissions.Behavioral impact
Extension users now see a completion or failure state after btcli submits the signed transaction. Signing and chain execution semantics are otherwise unchanged.
Migration and runtime impact
This change is limited to the Python SDK and browser bridge. It requires no storage migration or runtime
spec_versionbump.Testing
Added a parametrized unit test verifying that successful and failed transaction outcomes are forwarded as
transaction.resultrequests.