fix(reading-chat): include memos for memo-comparison questions - #272
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
includeMemo: falseorsearchText: "感想", which caused the app to omit full memo text or accidentally filter out records.Description
includeMemo=truefor questions about memo body, length, character count, or content comparisons. (apps/api/src/application/usecases/reading-chat/ask-reading-chat.ts)applyQuestionIntentwhich detects memo-related and comparison-related intent from the question and enforcesincludeMemo: true, and for comparisons setssearchTexttoundefinedandlimittoMAX_LIMIT. (applyQuestionIntentin the same file)planQueryto callapplyQuestionIntentafter normalizing the planner result so the server side compensates for planner variation. (planQuerychanges)apps/api/src/application/usecases/reading-chat/ask-reading-chat.spec.ts)Testing
pnpm --filter api test -- --runInBand application/usecases/reading-chat/ask-reading-chat.spec.ts, and the spec passed: 5 tests, 0 failures.pnpm --filter api exec eslint src/application/usecases/reading-chat/ask-reading-chat.ts src/application/usecases/reading-chat/ask-reading-chat.spec.ts, which succeeded.pnpm --filter api check-types, which failed due to pre-existing Prisma-generated typing errors in unrelated files (ai-summary.tsanddiscovery.ts); there are no type errors introduced by the changed files.Codex Task