fix: strictly type sub and data parameters in alert-broadcaster.ts (#1976)

[nimkarprachi17]

🛑 STOP: Assignment & File Scope Check

• I am assigned to this issue.
• I verified that this PR ONLY touches the required files.

📋 PR Summary & Link

• Closes [TYPES] Strictly type parameters in alert-broadcaster.ts #1976
• Summary: Replaces any types for the sub and data parameters in apps/api/src/cron/alert-broadcaster.ts with strict interfaces. Created a new apps/api/src/types/notification.types.ts file containing NotificationSubscriber (matching the actual shape of rows from the notification_subscribers table — id, phone, language, channels, district, is_active) and NotificationAlertData (covering medicineName, batchNumber, district, expiryDate as used across counterfeit, recall, and expiry alert types). Note: this cron job broadcasts via SMS/WhatsApp rather than browser Web Push, so the types reflect the actual subscriber/payload shape used in the code rather than the web-push library's PushSubscription type.

📸 Proof of Work (Screenshots / Logs)

🏷️ PR Type

• ♻️ type: refactor

✅ Checklist

• My PR has a linked issue (Closes #1976)
• I have pulled the latest main and resolved any conflicts

---

Files changed:

• apps/api/src/cron/alert-broadcaster.ts — replaced sub: any → sub: NotificationSubscriber, data: any → data: NotificationAlertData in sendNotificationToSubscriber, and updated getLocalizedMessage's data parameter to use NotificationAlertData
• apps/api/src/types/notification.types.ts — new file with NotificationSubscriber and NotificationAlertData interfaces

[github-actions]

🎉 Congratulations @nimkarprachi17! Your Pull Request "fix: strictly type sub and data parameters in alert-broadcaster.ts (#1976)" has been successfully merged by @dipexplorer.

Thank you for your valuable contribution to SahiDawa! 🇮🇳
If this was for GSSoC 2026, your work is officially merged and valid. Keep up the great work and feel free to claim other open issues. 🚀

Follow us on LinkedIn: https://www.linkedin.com/company/ratloopz/ to get shoutout