Fix : Replaced any types in Alerts Page with strict interfaces#2152
Merged
dipexplorer merged 1 commit intoJun 20, 2026
Conversation
Contributor
|
🎉 Congratulations @hrx01-dev! Your Pull Request " Fix : Replaced any types in Alerts Page with strict interfaces" has been successfully merged by @dipexplorer. Thank you for your valuable contribution to SahiDawa! 🇮🇳 Follow us on LinkedIn: https://www.linkedin.com/company/ratloopz/ to get shoutout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛑 STOP: Assignment & File Scope Check
Warning
PRs with unrelated files will not be reviewed and may be closed.
📋 PR Summary & Link
**Closes [Bug] Replace
anytypes in Alerts Page with strict interfaces #2078 **Summary:
Created an Alert interface containing all the expected properties of the alert object (like id, cdsco_approval_status, is_counterfeit_alert, alert_type, brand_name, batch_number, etc.).
Updated the useState hook for allAlerts to use Alert[] instead of any[].
Updated the handleShareAlert function signature to accept alert: Alert instead of alert: any.
For formatRelativeTime, I added a || null fallback so that it receives null instead of undefined when both dates are missing.
For the CopyButton, I added a || "" fallback so that it receives an empty string instead of undefined when alert.batch_number is absent.
📸 Proof of Work (Screenshots / Logs)
Important
No Pull Request will be merged without proof of testing!
Please drag & drop your screenshots/GIFs here:
🏷️ PR Type
type: bugtype: featuretype: docstype: testingtype: securitytype: performancetype: designtype: refactortype: devopstype: accessibility✅ Checklist
Closes #123)mainand resolved any conflicts