Fix : Background sync listener unregistered prematurely on Report Wizard unmount#2160
Merged
Conversation
github-actions
Bot
added
gssoc:approved
github-project-automation
Bot
moved this from 📥 Backlog
to 🎉 Merged
in SahiDawa Workflow
Contributor
|
🎉 Congratulations @hrx01-dev! Your Pull Request "Fix : Background sync listener unregistered prematurely on Report Wizard unmount" has been successfully merged by @dipexplorer. Thank you for your valuable contribution to SahiDawa! 🇮🇳 Follow us on LinkedIn: https://www.linkedin.com/company/ratloopz/ to get shoutout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛑 STOP: Assignment & File Scope Check
Warning
PRs with unrelated files will not be reviewed and may be closed.
📋 PR Summary & Link
(ServiceWorkerProvider.tsx): TheinitBackgroundSynchook is now initialized when the Service Worker provider mounts on the root layout. This ensures that whenever the user regains internet connectivity—regardless of which page they are on—any pending reports saved locally will auto-sync and they will be notified with a success toast.ReportWizard.tsx): I removedinitBackgroundSyncfrom the wizard component. However, the wizard still loads the pending count locally, and it now listens for a new "reports-synced" custom event dispatched by the global provider so that the "pending sync" UI badge instantly reflects changes if the user happens to have the wizard page open while coming back online.📸 Proof of Work (Screenshots / Logs)
Important
No Pull Request will be merged without proof of testing!
Please drag & drop your screenshots/GIFs here:
🏷️ PR Type
type: bugtype: featuretype: docstype: testingtype: securitytype: performancetype: designtype: refactortype: devopstype: accessibility✅ Checklist
Closes #123)mainand resolved any conflicts