Add unified MaskBuilder class replacing mixin-based factory pattern#30
Draft
Copilot wants to merge 2 commits intofeature/refactor-maskbuilder-for-xaifrom
Draft
Add unified MaskBuilder class replacing mixin-based factory pattern#30Copilot wants to merge 2 commits intofeature/refactor-maskbuilder-for-xaifrom
MaskBuilder class replacing mixin-based factory pattern#30Copilot wants to merge 2 commits intofeature/refactor-maskbuilder-for-xaifrom
Conversation
Co-authored-by: matejpekar <69220871+matejpekar@users.noreply.github.com>
Copilot
AI
force-pushed
the
copilot/simplify-mask-builders
branch
from
February 23, 2026 20:24
6dcea26 to
2224b62
Compare
Copilot
AI
changed the title
[WIP] Simplify mask builders to a single class
Add unified Feb 23, 2026
MaskBuilder class replacing mixin-based factory pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mask builder system required composing 12+ mixin classes via
MaskBuilderFactoryto get a usable builder — opaque, fragile, and hard to type correctly.Changes
New
MaskBuilderclass (mask_builders/builder.py): Single concrete class with explicit, typed init arguments. No mixins, no factory. Implements all pipeline stages (storage allocation, coordinate scaling, scalar expansion, edge clipping, aggregation) directly.storage: Literal["memmap", "in-memory"]aggregation: Literal["mean", "max"]auto_scale: bool— auto-computes mask extents and scales coordinates from source to mask spaceexpand_scalars: bool— GCD-compressed per-tile scalar expansionStorageTypeandAggregationTypetype aliases exported for annotations__init__.py: ExportsMaskBuilder,StorageType,AggregationTypealongside existing symbols (fully backward-compatible; all mixin classes andMaskBuilderFactorypreserved).Usage
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.