Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR migrates the zenko package build from tsup to tsdown (scripts and bundler config), adds Bun types to TypeScript configs, bumps several devDependencies in the repo, and updates runtime/dev deps in the examples package. A comment in AGENTS.md was corrected to reference tsdown. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/examples/package.json (1)
24-24: Update peerDependency to reflect TypeScript 6.x compatibility.
packages/zenko/package.jsondeclarespeerDependencies: { "typescript": "^5" }, butpackages/examplesuses TypeScript 6.0.2. Bothtsconfig.jsonfiles are already configured correctly for TypeScript 6.x (strict mode enabled, modern module resolution), so the code is compatible.Consider updating the peerDependency to
"^5 || ^6"to accurately reflect that TypeScript 6.x works with the codebase.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/examples/package.json` at line 24, Update the peerDependencies entry for TypeScript so it reflects compatibility with both v5 and v6: locate the peerDependencies block where "typescript": "^5" is declared (peerDependencies -> "typescript") and change the version string to "^5 || ^6" to match the examples package using "typescript": "6.0.2" and indicate support for TypeScript 6.x.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/zenko/package.json`:
- Around line 69-72: The package.json shows a devDependency on "typescript":
"6.0.2" but peerDependencies lists "typescript": "^5", creating a mismatch;
update the peerDependencies entry for TypeScript in package.json (the
"peerDependencies" block and the "typescript" key) to reflect supported ranges
(for example "^5 || ^6") or confirm and set the single supported major version
to match dev/test (e.g., "^6") to ensure consumers and developers have
consistent TypeScript expectations.
---
Nitpick comments:
In `@packages/examples/package.json`:
- Line 24: Update the peerDependencies entry for TypeScript so it reflects
compatibility with both v5 and v6: locate the peerDependencies block where
"typescript": "^5" is declared (peerDependencies -> "typescript") and change the
version string to "^5 || ^6" to match the examples package using "typescript":
"6.0.2" and indicate support for TypeScript 6.x.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 72a1ec21-bbe4-49df-ae7f-55c647a91900
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (8)
AGENTS.mdbunfig.tomlpackage.jsonpackages/examples/package.jsonpackages/examples/tsconfig.jsonpackages/zenko/package.jsonpackages/zenko/tsconfig.jsonpackages/zenko/tsdown.config.ts
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #74 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 16 16
Lines 2309 2309
=======================================
Hits 2261 2261
Misses 48 48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
Documentation
Chores