-
Notifications
You must be signed in to change notification settings - Fork 6
TypeLayout Rework #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chronicl
wants to merge
161
commits into
RayMarch:v2.0.0-beta.1
Choose a base branch
from
chronicl:layout2
base: v2.0.0-beta.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aneous usage in GpuLayout derive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeLayoutReworkThis PR reworks
TypeLayoutfor three purposes:type_layoutmodule.New traits and types
Here is a walkthrough of all new traits and the most important types
File structure
Now a bit about what each of the new files contains. We'll start with the
type_layout/layoutabledirectory:mod.rscontains the definition ofLayoutableTypeand it's nested enum variants such asVector,SizedStructand others.Displayimpls can also be found herealign_size.rscontains all layout calculations necessary to define aTypeLayoutfor aLayoutableType. Once the storage/uniform buffer any api has been reworked slightly, this will be the only file containing layout calculations in all of shame.builder.rscontains an infallible builder implementation forSizedStructand a fallibleLayoutableType::struct_from_partsir_compat.rscontainsTryFromconversion code ofLayoutableTypetoStoreTypeand the other way around. TheStoreTypetoLayoutableTypeconversion will be removed upon the storage/uniform buffer any api rework - it's currently functioning as temporary glue.Otherwise there is mostly
type_layout/mod.rs, which contains theTypeLayout,GpuTypeLayout,Reprdefinitions andtype_layout/construction.rs, which containsTypeLayout::new_layout_forand theGpuTypeLayoutconstruction and conversion code showcased above.Final remarks
GpuTypeLayoutis currently hooked up for cpu and gpu layout comparison, however it is not yet hooked up for storage/uniform buffer creation, which currently uses it's own layout calculation and verification functions - those can fully be replaced withGpuTypeLayout, which will be done in a follow up storage/uniform buffer any api rework PR.The PR is ready for review!