Fix: text editing, inspector timing, welcome card polish#3
Open
Razee4315 wants to merge 2 commits into
Open
Conversation
- Inline text editor now uses reactive position/size so it tracks the label when the canvas resizes (the inspector opening was leaving the edit box at stale coords, so typing/selecting appeared broken). Fixes create + double-click to edit, and the missing text/shape bars in the timeline (no text could be made). - Reserve the inspector column while a drawing tool is armed, so picking the Text tool shows the panel immediately and placing an element no longer reflows the canvas (which was jumping the edit box). - Welcome card: same-height Skip + red CTA (no oversized button), simpler copy with the em-dashes removed.
Per user feedback, timeline blocks (zoom, notes, speed, cut, trim) now drag exactly to where you drop them with no magnetic snapping or dashed guide line. Removes the snapBand/snapTargets/nearestTarget helpers, the snapGuide signal and its render, and the .tl-snapguide style. The adaptive ruler ticks (3b) stay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes from user testing of the UI upgrade.
Still open: a timeline simplification request (clarifying with the user).