Skip to content

Conversation

@badasahog
Copy link
Contributor

closes #7069

There's a lot I can do from here to remove static/global objects and speed up the code.

More to come.

@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.97%. Comparing base (ddaeb4c) to head (7b3438e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7206   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files          87       87           
  Lines       16741    16741           
=======================================
  Hits        16569    16569           
  Misses        172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Jul 23, 2025

  • HEAD=pythonRemoval stopped early for as.data.table.array improved in #7010
  • HEAD=pythonRemoval slower P<0.001 for memrecycle regression fixed in #5463
    Comparison Plot

Generated via commit 7b3438e

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 45 seconds
Installing different package versions 10 minutes and 42 seconds
Running and plotting the test cases 3 minutes and 26 seconds

@MichaelChirico
Copy link
Member

Thanks! I will allow this to dwell for a while (say 3-6 months after the issue was posted) in case the original authors/pydatatable maintainers decide to weigh in

@badasahog
Copy link
Contributor Author

I think it can be confirmed by just looking at the code? It's pretty clear from the datatable codebase that the paths have diverged for some time now.

@MichaelChirico
Copy link
Member

I'm not sure if there's another repo (possibly private?) that has been split off

Copy link
Member

@ben-schwen ben-schwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM TY

@ben-schwen ben-schwen merged commit 6f8bb9e into master Dec 26, 2025
11 checks passed
@ben-schwen ben-schwen deleted the pythonRemoval branch December 26, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remnants of compatibility with python datatable library dilute code

3 participants