-
Notifications
You must be signed in to change notification settings - Fork 1k
removed python compatibility #7206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7206 +/- ##
=======================================
Coverage 98.97% 98.97%
=======================================
Files 87 87
Lines 16741 16741
=======================================
Hits 16569 16569
Misses 172 172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Generated via commit 7b3438e Download link for the artifact containing the test results: ↓ atime-results.zip
|
|
Thanks! I will allow this to dwell for a while (say 3-6 months after the issue was posted) in case the original authors/pydatatable maintainers decide to weigh in |
|
I think it can be confirmed by just looking at the code? It's pretty clear from the datatable codebase that the paths have diverged for some time now. |
|
I'm not sure if there's another repo (possibly private?) that has been split off |
ben-schwen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM TY

closes #7069
There's a lot I can do from here to remove static/global objects and speed up the code.
More to come.