Create fake hourly profiles for github tests; fix logs#26
Merged
Conversation
ahamilton5
approved these changes
Apr 17, 2026
ahamilton5
left a comment
There was a problem hiding this comment.
Verbose logs fix works great. Thanks, Patrick.
kodiobika
approved these changes
Apr 21, 2026
Contributor
kodiobika
left a comment
There was a problem hiding this comment.
Thanks for doing this! LGTM
…ompt for the charge code itself)
This was referenced Apr 22, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #22 and #19:
recf.pyto create fake CF profiles with the newGSw_FakeDataswitch is active, allowing us to avoid ~12 GB of data download and caching for the runner testsTechnical details
Implementation notes
Fake profiles
make_fake_profiles()function is added torecf.py. To make the profiles somewhat realistic in terms of min/mean/max (but not temporal shape), we randomly sample from the two-state [0,1] array, where probability(1) = CF [fraction].reeds/remote.py.runbatch.py, we check to make sure all the cases in a batch use the sameGSw_FakeDatasetting (since we download the files shared by all runs)Logs
The verbose logging came from this line: https://github.nrel.gov/ReEDS/ReEDS-2.0/pull/1927/files#diff-a48c953794de025c1a499dbd77153a1da54ebb6bcd68499d4509b32bc4b8477fR21. Because a bokehpivot import was added to
reeds.output_calc, and because bokeh uses its own debug-level logging, all the python scripts started using debug-level logging. This PR reverts that change, so now the logs are back to normal.Additional changes
meta.csv(it wasn't working since we don't have any tags on this repo yet)Switches added/removed/changed
GSw_FakeData(default 0): Use fake capacity factor profiles (for TESTING ONLY when you do not want to download the real CF data)Issues resolved
Validation, testing, and comparison report(s)
Zero change for the Pacific test case: results-v20260416_mainM0_Pacific,v20260416_fakeM0_Pacific.pptx
The
github_Pacificcase finished for me locally.Here are histograms of the CF for a couple random samples:
Checklist for author
Details to double-check
General information to guide review
Did you use LLM tools (chatbot or copilot) in the preparation of this PR? If so, describe how
No