Skip to content

Update links to point to new repo#54

Merged
kennedy-mindermann merged 13 commits into
mainfrom
km/general-cleanup
Apr 23, 2026
Merged

Update links to point to new repo#54
kennedy-mindermann merged 13 commits into
mainfrom
km/general-cleanup

Conversation

@kennedy-mindermann
Copy link
Copy Markdown
Contributor

@kennedy-mindermann kennedy-mindermann commented Apr 23, 2026

Summary

This PR updates links to point to the new documentation site. It also updates several links from "nrel.gov" to "nlr.gov"

Technical details

Implementation notes

Additional changes

Switches added/removed/changed

Issues resolved

Known incompatibilities

Relevant sources or documentation

Charge code for review

Validation, testing, and comparison report(s)

Checklist for author

Details to double-check

  • Charge code provided for review
  • Included comparison reports for appropriate test cases
  • Documentation updated if necessary
  • If input data added/modified:
    • Dollar year recorded and converted to 2004$ for GAMS
    • Timeseries are in Central Time
    • Units are specified
    • Preprocessing steps have been documented and committed to ReEDS_Input_Processing
    • New large data files handled with .h5 instead of .csv
    • If spatially resolved inputs are modified, the following visualizations for each file are included in the PR description (time-averaged if the inputs are time-resolved):
      • Map of absolute values before
      • Map of absolute values after
      • Map of differences: (after - before) or (after / before)
    • If entries are added/removed/changed in the EIA-NEMS unit database:
      • Changes have been committed to ReEDS_Input_Processing
      • hourlize/resource.py was rerun to regenerate the existing/prescribed VRE capacity data
  • Code formatting standardized
  • Reusable functions used where possible instead of copy/pasted code

General information to guide review

  • Zero impact on results of default case
  • No large data file(s) added/modified
  • No substantive impact on runtime for full-US reference case
  • No substantive impact on folder size for full-US reference case
  • No change to process flow (runbatch.py, d_solve_iterate.py)
  • No change to code organization
  • No change to package requirements (environment.yml or Project.toml)

Did you use LLM tools (chatbot or copilot) in the preparation of this PR? If so, describe how

Tag points of contact here if you would like additional review of the relevant parts of the model

@kennedy-mindermann kennedy-mindermann changed the title Update links & PR template Update links to point to new repo Apr 23, 2026
Copy link
Copy Markdown
Contributor

@bsergi bsergi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small edits but otherwise looks good to me. Thanks Kennedy!

Comment thread hourlize/README.md Outdated
Comment thread preprocessing/README.md Outdated
kennedy-mindermann and others added 3 commits April 23, 2026 10:56
Co-authored-by: Brian Sergi <bsergi@nlr.gov>
Co-authored-by: Brian Sergi <bsergi@nlr.gov>
@kennedy-mindermann kennedy-mindermann merged commit 3a3bd81 into main Apr 23, 2026
10 checks passed
@kennedy-mindermann kennedy-mindermann deleted the km/general-cleanup branch April 23, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants