Skip to content

Update publication links#66

Merged
kennedy-mindermann merged 8 commits into
mainfrom
km/publications
May 5, 2026
Merged

Update publication links#66
kennedy-mindermann merged 8 commits into
mainfrom
km/publications

Conversation

@kennedy-mindermann
Copy link
Copy Markdown
Contributor

Summary

This PR updates all publication links from nrel.gov to nlr.gov. It also updates the GitHub usernames in the PR template.

Issues resolved

Will close #60 & #55.

Known incompatibilities

Relevant sources or documentation

Validation, testing, and comparison report(s)

I didn't do any testing since this doesn't change the model.

Checklist for author

Details to double-check

  • Charge code provided to reviewers
  • Included comparison reports for appropriate test cases
  • Documentation updated if necessary
  • If input data added/modified:
    • Dollar year recorded and converted to 2004$ for GAMS
    • Timeseries are in Central Time
    • Units are specified
    • Preprocessing steps have been documented and committed to ReEDS_Input_Processing
    • New large data files handled with .h5 instead of .csv
    • If spatially resolved inputs are modified, the following visualizations for each file are included in the PR description (time-averaged if the inputs are time-resolved):
      • Map of absolute values before
      • Map of absolute values after
      • Map of differences: (after - before) or (after / before)
    • If entries are added/removed/changed in the EIA-NEMS unit database:
      • Changes have been committed to ReEDS_Input_Processing
      • hourlize/resource.py was rerun to regenerate the existing/prescribed VRE capacity data
  • Code formatting standardized
  • Reusable functions used where possible instead of copy/pasted code

General information to guide review

  • Zero impact on results of default case
  • No large data file(s) added/modified
  • No substantive impact on runtime for full-US reference case
  • No substantive impact on folder size for full-US reference case
  • No change to process flow (runbatch.py, d_solve_iterate.py)
  • No change to code organization
  • No change to package requirements (environment.yml or Project.toml)

Did you use LLM tools (chatbot or copilot) in the preparation of this PR? If so, describe how

Tag points of contact here if you would like additional review of the relevant parts of the model

Copy link
Copy Markdown
Contributor

@wesleyjcole wesleyjcole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I noticed we still have a few more lingering "nrel" mentions, including:

  • aws_setup.sh has references to github.nrel.gov
  • runbatch.py has a reference to github.com/nrel
  • sources.csv has several github.nlre.gov links
  • developer_best_practices.md has a nrel.sharepoint.com link
  • postprocessing_tools.md has a link to the NREL-Sienna
  • setup.md has a few nrel.sharepoint.com links
  • user_guide.md has a link to a nrel-my.sharepoint.com
  • transmission.py has a link to https://github.nrel.gov/ReEDS/TSC (so does the ReadMe.md in inputs/transmission)
  • There are several ReadMe.md files with github.nrel.gov links

Happy to address some or all of these, and happy to have them included in this PR or addressed via a separate PR.

@kennedy-mindermann kennedy-mindermann merged commit 3928986 into main May 5, 2026
13 checks passed
@kennedy-mindermann kennedy-mindermann deleted the km/publications branch May 5, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tags in pull request template use old github.nrel.gov usernames

2 participants