End ReEDS run early if no valid scenarios#93
Merged
Conversation
patrickbrown4
approved these changes
May 18, 2026
Contributor
patrickbrown4
left a comment
There was a problem hiding this comment.
Thanks Kennedy, some suggestions but otherwise looks good
Comment on lines
+889
to
+890
| f'Specified single={single} but available cases are: ' | ||
| + ', '.join([c for c in df_cases.columns]) |
Contributor
There was a problem hiding this comment.
Personally I would revert and keep these on their own lines as I think that's easier to read
| single=single, | ||
| skip_checks=skip_checks, | ||
| ) | ||
| all_case_names = list(df_cases.columns) |
Contributor
There was a problem hiding this comment.
For readability, define further down, next to the one place it's used
Co-authored-by: Patrick Brown <25125211+patrickbrown4@users.noreply.github.com>
Co-authored-by: Patrick Brown <25125211+patrickbrown4@users.noreply.github.com>
Co-authored-by: Patrick Brown <25125211+patrickbrown4@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
runreeds.pyto end the run in a few different places if there are no valid scenarios left.I also did a minor update to one of the existing error messages so it was easier to read.
Validation, testing, and comparison report(s)
I didn't do a full run since it doesn't change the model itself. I did check all combinations of getting a run started to make sure it behaved as expected.
Checklist for author
Details to double-check
hourlize/resource.pywas rerun to regenerate the existing/prescribed VRE capacity dataGeneral information to guide review
Did you use LLM tools (chatbot or copilot) in the preparation of this PR? If so, describe how
Tag points of contact here if you would like additional review of the relevant parts of the model