fix(awn): use PROTOCOL_VERSION in tests, fix release-cli trigger#160
Merged
Conversation
- Replace hardcoded '1.3' in crypto tests with PROTOCOL_VERSION constant - Replace hardcoded signature assertion with sign-then-verify roundtrip - Add resolve-tag job to release-cli.yml so workflow_dispatch works - Have release.yml dispatch release-cli.yml after publish (GITHUB_TOKEN releases don't trigger release events)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CI failure from https://github.com/ReScienceLab/agent-world-network/actions/runs/23486244809
Changes
Rust test fixes
test_domain_separator_values: replaced hardcoded"1.3"withPROTOCOL_VERSIONconstant so the test survives version bumpstest_compat_sign_verify_matches_ts: replaced hardcoded signature string with sign-then-verify roundtrip (signature includes version in domain separator, so cannot be a static string)Release CLI workflow fix
resolve-tagjob torelease-cli.ymlthat resolves the tag from either the release event or the latest release (forworkflow_dispatch)if: github.event_name == 'release'guards on upload/homebrew jobs soworkflow_dispatchworks end-to-endgh workflow run release-cli.ymlstep inrelease.ymlafter publish, sinceGITHUB_TOKEN-created releases don't triggerrelease: [published]eventsTesting