fix: add npm-publish job to release.yml, robust backmerge#31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two structural bugs in the release pipeline:
npm never published after v0.2.2:
release.ymlcreates the GitHub Release usingGITHUB_TOKEN. GitHub explicitly does not trigger other workflows from events caused byGITHUB_TOKEN, sopublish.yml(listening onrelease: published) was never triggered for v0.2.3+.Backmerge fails on every release: Squash-merge strategy causes git history to diverge between
mainanddevelop, making directgit merge mainfail with conflicts every time.Changes
release.ymlnpm-publishjob (runs aftergithub-release, usesNPM_TOKEN) — no longer relies on the brokenrelease: publishedtrigger chainchore/backmerge-vX.Y.Zbranch with-X theirsand open a PR todevelopinstead of failingpublish.ymlworkflow_dispatchtrigger as a manual escape hatch for one-off backfillsv0.2.3 backfill
Triggered
publish.ymlviaworkflow_dispatch— v0.2.3 is now live on npm (@resciencelab/declaw@0.2.3).