fix: add changeset publish to release script#18
Merged
Conversation
The release script only ran `npm run build` (tsc) without actually publishing to npm. This caused the changesets/action to succeed without creating a GitHub release or publishing v0.2.2 to the registry. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release workflow ran successfully on this CI run after merging version packages PR #17, but no GitHub release or npm publish happened for v0.2.2.
Root cause: The
releasescript inpackage.jsonwasnpm run build(justtsc), which never calledchangeset publishto actually publish to npm and create git tags for GitHub releases.Fix
Change the
releasescript from:to:
This ensures the
changesets/actionpublish step actually pushes the package to npm and creates the GitHub release tags.After merging
Re-run the release workflow (
workflow_dispatch) to publish the missed v0.2.2 release.