fix: resolve missing textures and frame count errors in Phaser#24
Merged
Conversation
- Fix star_idle frame 48 not found: change frameTotal - 1 to frameTotal - 2 (Phaser's frameTotal includes __BASE frame, causing off-by-one) - Fix coffee_machine texture not found: update filename from coffee-machine-spritesheet to coffee-machine-v3-grid.webp - Update all game.js asset references to match actual versioned filenames: star-idle-v5.png, sofa-idle-v3.png, desk-v3, sync-animation-v3-grid, flowers-bloom-v2, error-bug frame size 220x220 - Use dynamic frame counts instead of hardcoded values for animations - Remove references to non-existent assets (star-researching-spritesheet, sofa-busy-spritesheet, desk-v2.png) Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two Phaser console errors on the live site (agentworlds.ai/w/super-office-g3ql):
Frame "48" not found in texture "star_idle"-- off-by-one in frame count calculationTexture "coffee_machine" not found-- asset filenames in game.js don't match actual files on diskRoot Cause
starIdleFrameMaxwas computed asframeTotal - 1, but Phaser'sframeTotalincludes the__BASEframe. For a 48-frame spritesheet,frameTotalis 49, so49 - 1 = 48is out of range (valid: 0-47). Should beframeTotal - 2.game.jsreferenced old unversioned filenames (coffee-machine-spritesheet,star-idle-spritesheet, etc.) that don't exist on disk. The actual files use versioned names (coffee-machine-v3-grid.webp,star-idle-v5.png, etc.).Changes
starIdleFrameMaxcalculation:frameTotal - 1->frameTotal - 2inindex.htmlandelectron-standalone.htmlgame.jsto match actual versioned filenames on diskframeTotal - 2) instead of hardcoded valuesstar-researching-spritesheet,sofa-busy-spritesheet,desk-v2.png)error_bugframe size to 220x220 (matchingindex.html)