Fix for autocorrect change not sent to UITextField.rText, .rAttributedText#13
Open
creister wants to merge 2 commits intoReactiveKit:masterfrom
Open
Fix for autocorrect change not sent to UITextField.rText, .rAttributedText#13creister wants to merge 2 commits intoReactiveKit:masterfrom
creister wants to merge 2 commits intoReactiveKit:masterfrom
Conversation
added 2 commits
July 8, 2016 09:43
Note that this makes rText "chattier" and reports more than just changes.
Author
|
note that UITextView.rText has a similar issue. See https://github.com/ReactiveX/RxSwift/pull/371/files |
| unwrappedSelf.rText.value = unwrappedSelf.text | ||
| updatingFromSelf = false | ||
| // only send to rText if value changed, as .AllEditingEvents reports more than just changes | ||
| if unwrappedSelf.rText.value != unwrappedSelf.text { |
Contributor
There was a problem hiding this comment.
Is there any way to avoid this? I don't like the idea of performing string comparison O(n) on each keystroke...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UITextField does not send UIControlEvents.EditingChanged when accepting an autocorrect change.
To work around this, I've observed UIControlEvents.AllEditingEvents and only sending value to rText/rAttributedText when the value has changed.
Other reactive frameworks have had this issue too, see ReactiveX/RxSwift@8a15b92