Open
Conversation
…om react 17 2. Switched off react/prop-types since we are not using types 3. Ran prettier 4. Changed file extension from .eslintrc to .eslintrc.js
Tejas-ChandraShekarRaju
requested review from
DeRaowl,
Neha,
pallabez and
prakashchoudhary07
DeRaowl
suggested changes
Nov 12, 2022
| }, | ||
| "eslint-webpack-plugin": { | ||
| "version": "3.1.1", | ||
| "resolved": "https://registry.npmjs.org/eslint-webpack-plugin/-/eslint-webpack-plugin-3.1.1.tgz", |
There was a problem hiding this comment.
Can you check why this has been updated?
Contributor
Author
There was a problem hiding this comment.
@DeRaowl Changed to parser: "@babel/eslint-parser" from parser: "@babel/eslint". For this I've added the dependency in package.json. Hence the update in package-lock.json
|
|
||
| }) | ||
|
|
||
| it("Should fire event on click ascending", async () => { |
There was a problem hiding this comment.
Why test related to fireEvent removed?
Contributor
Author
There was a problem hiding this comment.
Hi @DeRaowl we moved this click event from the cursor to the header. So we have to implement tests for the header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Build was failing because of wrong extension. .eslintrc couldn't detect module.exports hence changed extension to .eslintrc.js
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: