Adding DONE to task status options#499
Adding DONE to task status options#499chandrareddy7 wants to merge 20 commits intoRealDevSquad:developfrom
Conversation
✅ Deploy Preview for staging-my ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chandrareddy7
changed the title
| {{#if @dev}} | ||
| {{#if (not (or (eq taskStatus.key this.TASK_KEYS.AVAILABLE) (eq taskStatus.key this.TASK_KEYS.COMPLETED)))}} | ||
| <option | ||
| value={{taskStatus.key}} | ||
| selected={{eq taskStatus.key this.status}} | ||
| > | ||
| {{taskStatus.displayLabel}} | ||
| </option> | ||
| {{/if}} |
There was a problem hiding this comment.
Instead of adding conditions inside a loop to populate the task status, can we just have two separate availableTaskStatusList?
There was a problem hiding this comment.
You meant to maintain two seperate lists in the constants file itself?
There was a problem hiding this comment.
Yes. Something like that where we don't have to write extra logic to maintain the old flow.
| </option> | ||
| {{/if}} | ||
| {{else}} | ||
| {{#if (not (or (eq taskStatus.key this.TASK_KEYS.DONE)))}} |
There was a problem hiding this comment.
If we add new logic under the old flow, won't it defeat the purpose of adding a feature flag?
There was a problem hiding this comment.
We have added new task status to constants file. So have to do this.
Can we do it in any other way?
|
Also Please update your design doc in PR |
* feat: cancel OOO button enabled * fix: styling issues * feat: feature flag added * fix: feature behind flag * fix: test file * fixed lint error * removed redundancy
* create button to allow multiple extensions * add test for multiple extension request form * fix style * fix style * fix style and refactor component * refactor form and details and fix styles * fix test cases * final fix
…either approved or denied (RealDevSquad#503) * Feat : Added reviewed by log in extension status modal * Test : Added test cases to verify review log
…s://github.com/chandrareddy7/website-my into Add-UNASSIGNED-and-DONE-in-task-status-options
…s://github.com/chandrareddy7/website-my into Add-UNASSIGNED-and-DONE-in-task-status-options
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| setTimeout( | ||
| (this.isSubmitButtonDisabled = true), | ||
| this.args.closeModel(), | ||
| 2000 | ||
| ); |
There was a problem hiding this comment.
The setTimeout usage here is incorrect. It's currently executing this.isSubmitButtonDisabled = true immediately, then passing the result of this.args.closeModel() as the first argument to setTimeout.
To fix this, wrap the operations in a callback function:
setTimeout(() => {
this.isSubmitButtonDisabled = true;
this.args.closeModel();
}, 2000);This ensures both operations execute after the 2000ms delay as intended.
| setTimeout( | |
| (this.isSubmitButtonDisabled = true), | |
| this.args.closeModel(), | |
| 2000 | |
| ); | |
| setTimeout(() => { | |
| this.isSubmitButtonDisabled = true; | |
| this.args.closeModel(); | |
| }, 2000); |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| assert.dom('[ data-test-cancel-status-OOO]').hasProperty('button'); | ||
| assert.dom('[ data-test-cancel-status-OOO]').hasText('Cancel OOO'); |
There was a problem hiding this comment.
The CSS selector in the test has an extra space at the beginning which could cause the test to fail. Change '[ data-test-cancel-status-OOO]' to '[data-test-cancel-status-OOO]' (remove the space after the opening bracket) to ensure the element is properly selected.
| assert.dom('[ data-test-cancel-status-OOO]').hasProperty('button'); | |
| assert.dom('[ data-test-cancel-status-OOO]').hasText('Cancel OOO'); | |
| assert.dom('[data-test-cancel-status-OOO]').hasProperty('button'); | |
| assert.dom('[data-test-cancel-status-OOO]').hasText('Cancel OOO'); |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
6 participants
Issue: #468
Design Doc: Link
Description:
Currently in task status options we are showing
AVAILABLEas an option.We are removing it as we do not want a user to UNASSIGN a task by themselves.
We are migrating our task status from
COMPLETEDtoDONE. SoCOMPLETEDtask status is replaced byDONE.Changes are under feature flag.
When dev is false we would have
AVAILABLEandCOMPLETEDin task status options.When dev is true we would have
DONEin task status options and we do not showAVAILABLE.Before changes:
After changes:
Update task status to DONE:
My.Tasks._.My._.Real.Dev.Squad.-.Google.Chrome.2023-10-08.17-45-25.mp4