fix(buy,sell): correct how the amount field handles grouped and rejected input - #918

Open

joshuakrueger-dfx wants to merge 18 commits into

stagingfrom

fix/ambiguous-amount-feedback

Commits on Aug 20, 2026

fix(buy,sell): tell the user an amount is ambiguous instead of failing generically
joshuakrueger-dfx
committed
9b0762f
fix(converter): drop the stale counter value when a conversion fails
joshuakrueger-dfx
committed
f9a0641
feat(buy,sell): resolve a thousands separator in the amount field instead of refusing it
joshuakrueger-dfx
committed
1df5eb7
test(goldens): cover the ambiguous-amount error state
joshuakrueger-dfx
committed
d0eaaec
test(goldens): add the ambiguous-amount baseline
joshuakrueger-dfx
committed
b1b0fd8
test(buy): pin that a changed amount is the one that gets confirmed
joshuakrueger-dfx
committed
f53215d
fix(l10n): describe what actually triggers the unreadable-amount notice
joshuakrueger-dfx
committed
6a38394
test(goldens): refresh the unreadable-amount baseline for the new wording
joshuakrueger-dfx
committed
0fa5775
fix(buy,sell): close the review findings on the amount field
joshuakrueger-dfx
committed
150a21b
test(goldens): add the sell unreadable-amount baseline
joshuakrueger-dfx
committed
cd40e64
test(goldens): drop the sell baseline that could never fail
joshuakrueger-dfx
committed
74e6b4d
fix(buy,sell): resolve mixed separators and restore the sell golden
joshuakrueger-dfx
committed
e3e20b5
test(goldens): add the sell snackbar baseline
joshuakrueger-dfx
committed
26a133c
fix(l10n): state the accepted form instead of the rejected condition
joshuakrueger-dfx
committed
7747988
test(goldens): refresh both baselines for the reworded notice
joshuakrueger-dfx
committed
fc63155
fix(buy,sell): drop the unreachable sell error branch and fix the caret
joshuakrueger-dfx
committed
0c2c5c9
fix(input): count only the separators dropped before the caret
joshuakrueger-dfx
committed
87aa017
test(input): pin which separator the caret math removes
joshuakrueger-dfx
committed
d9e0914

Navigation Menu

Uh oh!

fix(buy,sell): correct how the amount field handles grouped and rejected input - #918

fix(buy,sell): correct how the amount field handles grouped and rejected input#918
joshuakrueger-dfx wants to merge 18 commits into
stagingfrom
fix/ambiguous-amount-feedback

Commits on Aug 20, 2026

fix(buy,sell): tell the user an amount is ambiguous instead of failing generically

fix(converter): drop the stale counter value when a conversion fails

feat(buy,sell): resolve a thousands separator in the amount field instead of refusing it

test(goldens): cover the ambiguous-amount error state

test(goldens): add the ambiguous-amount baseline

test(buy): pin that a changed amount is the one that gets confirmed

fix(l10n): describe what actually triggers the unreadable-amount notice

test(goldens): refresh the unreadable-amount baseline for the new wording

fix(buy,sell): close the review findings on the amount field

test(goldens): add the sell unreadable-amount baseline

test(goldens): drop the sell baseline that could never fail

fix(buy,sell): resolve mixed separators and restore the sell golden

test(goldens): add the sell snackbar baseline

fix(l10n): state the accepted form instead of the rejected condition

test(goldens): refresh both baselines for the reworded notice

fix(buy,sell): drop the unreachable sell error branch and fix the caret

fix(input): count only the separators dropped before the caret

test(input): pin which separator the caret math removes