01a0672f - feat(history): label plain REALU transfers as received/sent - #969
Merged
Conversation
Incoming token transfers from a foreign wallet showed up as 'Kauf' in the transaction list, because the row widgets label purely by direction (customer report via RealUnit, 02.09.2026). Brokerbot purchases carry no DFX transaction, so the app cannot tell them apart on its own. The API now classifies every history transfer (backend#5353): purchase and sale for Brokerbot counterparties, transferIn/transferOut for plain token movements. The app stores that category (new transactions.category column, schema v3) and resolves the row title through a shared helper: DFX-backed transactions keep the direction-based buy/sell labels, categorized plain transfers render as received/sent, and rows without a category (legacy data, older API) keep the previous direction labels, so backend and app can roll out independently. Already-synced entries pick up their category on the next sync via the existing update path.
Widget tests now assert the concrete received/sent/buy/sell strings from the localization delegate instead of relative inequality.
Row titles now follow the theme instead of a hardcoded TextStyle, and the language files end with a newline.
A non-string category on the wire no longer throws in fromJson, so one bad event cannot abort the whole history sync.
Match the DTO majority convention. Drop the extra is-String guard and its type-mismatch test.
Same four rows as the baseline: inbound 10 is now Empfangen so the PNG diffs Kauf → Empfangen on that file.
TaprootFreakAI
marked this pull request as ready for review
September 7, 2026 06:00
Collaborator
Author
|
EN: DE: DetailsShared golden Open comments: none. |
TaprootFreak
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
Labels inbound REALU from an external wallet as Empfangen instead of Kauf, using the API category. The history screenshot diffs against the baseline from #967.
DE:
Beschriftet eingehende REALU von einer fremden Wallet als Empfangen statt Kauf, anhand der API-Kategorie. Der History-Screenshot diffed gegen die Baseline aus #967.
Details
Same four rows as #967. The shared golden
transaction_history_transfer_labelschanges +10 from Kauf to Empfangen and −10 from Verkauf to Gesendet. Brokerbot rows stay Kauf/Verkauf.Follows closed #965 (fork head could not be force-pushed after the rebase).