Revert #34: invite and promo links serve the 404 page - #35
Merged
Conversation
…)" This reverts commit 1555d93.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN. #34 made every invite and promo link serve the site's own 404 page instead of the landing. Before it, a shared link rendered the landing and answered
404; since it went live, a visitor following one is shown "page not found". This reverts it. The original defect — the404status that keeps share crawlers from reading the meta tags — is back with it, and that is the smaller of the two.DE. #34 hat dazu geführt, dass Einladungs- und Promo-Links die Fehlerseite ausliefern statt der Einladungsseite. Vorher zeigte ein geteilter Link die richtige Seite, nur mit falschem Status. Seit der Auslieferung sieht ein Besucher "Seite nicht gefunden". Das hier nimmt die Änderung zurück. Der ursprüngliche Fehler kommt damit zurück, ist aber der kleinere von beiden.
What was measured
On production, after #34 went live:
Before #34, the same URL answered
404with the landing shell and the injected code in its title.Verified on a preview deployment of this revert:
What the cause is not. The first suspicion was the rebuilt
GET-equivalent handed tocontext.next(). A branch that callscontext.next()with no argument was deployed to a preview and behaves exactly like #34 does, so that is not it. A probe build shows the path gate returningtrueandcontext.next()answering404with the site's 404 page for/invite/<code>— the asset lookup no longer resolves the_redirectsrewrite. Why #34 changes that is still open, which is the reason this reverts rather than patches.