Adding inter-mod compatibility back into Oritech for NeoForge 26.1.2 - #812
Open
jshipley wants to merge 3 commits into
Open
Adding inter-mod compatibility back into Oritech for NeoForge 26.1.2#812jshipley wants to merge 3 commits into
jshipley wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I took a completely different (and much more conservative) approach to compatibility for 26.1.2 than I did for 1.21.1
Some of the main goals this time around:
This is a semi large change, so I'll try to summarize the main components:
Added a new runCompatData task in build.gradle
Changed ResourceNodeFeature configuration (breaking change for any data packs that have customized this)
Recipe builders updated a little to allow for a "prefix" in recipe IDs
How Has This Been Tested?
For the world gen changes, I have tested with a combination of ATO and FTB Materials being loaded and unloaded. Their ores are included in the ore boulders when the mods are loaded, and not included if they're not loaded.
I've also reviewed the JSON files for the other recipes and made sure they looked good in JEI.
Checklist:
Please let me know if there are any compat features that existed in 1.21.1 that I skipped that you would prefer to include in 26.1.2