Skip to content

ci: the portal address is a secret, so the runner masks it in the log - #122

Merged
RobotSail merged 1 commit into
mainfrom
portal-url-secret
Sep 12, 2026
Merged

RobotSail merged 1 commit into
mainfrom
portal-url-secret

Conversation

@RobotSail

@RobotSail RobotSail commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

The job-level env: block is echoed at every step and minic version prints "portal … at ", so with MINIC_URL a repository variable the portal's address sat in every public run log. The value is now a repository secret of the same name; the runner masks every occurrence (env dump, minic version, error text). No behavior change. The variable is deleted after this merges.

Summary by CodeRabbit

  • Security

    • Workflow configuration now reads the portal address from protected secrets rather than repository variables.
    • The portal address is masked in benchmark and GPU test logs to reduce accidental exposure.
  • Chores

    • Updated workflow guidance to clarify that the portal address and access token are treated as secrets.
    • Benchmark and GPU test execution behavior remains otherwise unchanged.

The job-level env block is echoed at every step and `minic version` prints
"portal … at <url>": with MINIC_URL a repository variable, the portal's
address sat in every public run log. As a secret the runner masks every
occurrence. Same value, moved from the variable to a secret.
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 7e14eef0-21f9-40da-9d27-c67f11f2e56a

📥 Commits

Reviewing files that changed from the base of the PR and between f81a6cf and a5578be.

📒 Files selected for processing (2)
  • .github/workflows/benchmark.yml
  • .github/workflows/gpu-tests.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The benchmark and GPU test workflows now source MINIC_URL from repository secrets. Their comments document secret handling and runner masking.

Changes

Workflow secret configuration

Layer / File(s) Summary
Secret-backed MINIC_URL configuration
.github/workflows/benchmark.yml, .github/workflows/gpu-tests.yml
Both workflows read MINIC_URL from secrets.MINIC_URL. Comments identify the portal values as secrets and describe runner masking.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to a5578

The workflows now source the portal address from a masked secret without a demonstrated behavior regression.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the primary change: moving the portal address to a secret so the CI runner masks it in logs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch portal-url-secret

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@RobotSail
RobotSail merged commit fd5b552 into main Sep 12, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant