ci: the portal address is a secret, so the runner masks it in the log - #122
Conversation
The job-level env block is echoed at every step and `minic version` prints "portal … at <url>": with MINIC_URL a repository variable, the portal's address sat in every public run log. As a secret the runner masks every occurrence. Same value, moved from the variable to a secret.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe benchmark and GPU test workflows now source ChangesWorkflow secret configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The workflows now source the portal address from a masked secret without a demonstrated behavior regression. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The job-level
env:block is echoed at every step andminic versionprints "portal … at ", so withMINIC_URLa repository variable the portal's address sat in every public run log. The value is now a repository secret of the same name; the runner masks every occurrence (env dump,minic version, error text). No behavior change. The variable is deleted after this merges.Summary by CodeRabbit
Security
Chores