Skip to content

CherryPicked: [v2.11] feat(MTV-6088): add MTV-777 combined VM+populator inflight throttling test with DRS VM override - #613

Open
manage-repositories-app[bot] wants to merge 1 commit into
v2.11from
CherryPicked-feat/MTV-6088-vm-populator-inflight-throttling-DjfEm
Open

CherryPicked: [v2.11] feat(MTV-6088): add MTV-777 combined VM+populator inflight throttling test with DRS VM override#613
manage-repositories-app[bot] wants to merge 1 commit into
v2.11from
CherryPicked-feat/MTV-6088-vm-populator-inflight-throttling-DjfEm

Conversation

@manage-repositories-app

Copy link
Copy Markdown

Cherry-pick from main branch, original PR: #602, PR owner: prabinovRedhat

… test with DRS VM override (#602)

* feat(MTV-6088): VM+populator inflight throttling test with DRS disable (MTV-777)

* fix(MTV-6088): reduce to 2 VMs x 2 add_disks, VM_POPULATOR_INFLIGHT_LIMIT=2

* fix(MTV-6088): fix docstring limit value, add plan flags to AGENTS.md\n\nAssisted-by: PI (claude-sonnet-4-6-1m) <noreply@pi.dev>

* fix(MTV-6088): address CodeRabbit review — direct attr access, unused param, ValueError catch, shared lock\n\nAssisted-by: PI (claude-sonnet-4-6-1m) <noreply@pi.dev>

* fix(MTV-6088): correct shared-lock docstring — fixtures mutate different fields

* fix(MTV-6088): address CodeRabbit — clone_to_same_host docs and DRS override fail-fast

Clarify clone_to_same_host plan option docs and fail fast when per-VM DRS overrides are disabled on the cluster.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(MTV-6088): address CodeRabbit — runtime_host None check and TimeoutExpiredError docs

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(MTV-6088): address CodeRabbit — DRS provider guard, docstring, VM host name/id lookup

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(MTV-6088): split VM and populator throttling verifies; sequential event expectation

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(MTV-6088): fail fast when disable_drs_for_vms is set for OVA

Raise ValueError in prepared_plan for OVA providers and document that the flag is unsupported for OVA.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
@redhat-qe-bot

Copy link
Copy Markdown

⚠️ This cherry-pick had conflicts resolved by AI (claude/claude-opus-4-6-1m)

@prabinovRedhat — AI automatically resolved merge conflicts for this cherry-pick. Please review the changes carefully and verify correctness before merging.

@redhat-qe-bot2

Copy link
Copy Markdown

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

Note: You are an auto-verified user. Your PRs will be automatically verified and may be auto-merged when all requirements are met.

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: Disabled for this repository
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: All label categories are enabled (default configuration)

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (PR author or approvers)
  • /hold cancel - Unblock PR merging (PR author or approvers)
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message
  • /security-override - Set security check runs to pass (maintainers only)
  • /security-override cancel - Re-run security checks

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /automerge - Enable automatic merging when all requirements are met (maintainers and approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest build-container - Rebuild and test container image
  • /retest conventional-title - Validate commit message format
  • /retest all - Run all available tests

Container Operations

  • /build-and-push-container - Build and push container image (tagged with PR number)
    • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3
  • /cherry-pick-retry <branch> - Retry a failed cherry-pick (merged PRs only)

Branch Management

  • /rebase - Rebase this PR branch onto its base branch

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. Status Checks: All required status checks must pass
  3. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
  4. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

  • myakove
  • solenoci

Reviewers:

  • krcmarik
  • myakove
  • solenoci
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
  • automerge
AI Features
  • Conventional Title: Mode: fix (claude/claude-opus-4-6-1m)
  • Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6-1m)
  • Test Oracle: Triggers: approved (cursor/gpt-5.4-xhigh-fast); /test-oracle can be used anytime
Security Checks
  • Suspicious Path Detection: Monitors paths: .claude/, .vscode/, .cursor/, .devcontainer/, .pi/, .github/workflows/, .github/actions/
  • Committer Identity Check: Verifies last committer matches PR author
  • Mandatory: Security checks block merge (use /security-override to bypass — maintainers only)

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Container Builds: Container images are automatically tagged with the PR number
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

@prabinovRedhat

Copy link
Copy Markdown
Collaborator

@myakove, could you please close this? It looks like we don't need to backport it, and I don't have permission to close it.

@myakove

myakove commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@prabinovRedhat

Copy link
Copy Markdown
Collaborator

@myakove, could you please close this? It looks like we don't need to backport it, and I don't have permission to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants