Conversation
Text
6484093 to
6462e8e
Compare
TextText and Loctext
ddb0aa7 to
7e2dde4
Compare
mikeshulman
approved these changes
Oct 8, 2024
Collaborator
mikeshulman
left a comment
There was a problem hiding this comment.
Seems reasonable, looking in from the outside.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
Diagnosticmodule bundles diagnostics and text operations together. The planned lower-level debugging interface #138 could reuse text operations but not (high-level) diagnostics. This PR factors out text operations as new modulesTextandLoctextso that the debugging interface does not have to depend on theDiagnosticmodule.Here are all the bindings being moved:
Diagnostic.text(type)Text.tDiagnostic.text(function)Text.makeDiagnostic.textfText.makefDiagnostic.ktextfText.kmakefDiagnostic.loctext(type)Loctext.tDiagnostic.loctext(function)Loctext.makeDiagnostic.loctextfLoctext.makefDiagnostic.kloctextfLoctext.kmakefDiagnostic.string_of_textText.to_string