This repository was archived by the owner on May 5, 2019. It is now read-only.
move GKE quickstart first, namespace consistency#8
Open
kerneljake wants to merge 2 commits intoRedisLabs:masterfrom
kerneljake:patch-1
Open
move GKE quickstart first, namespace consistency#8kerneljake wants to merge 2 commits intoRedisLabs:masterfrom kerneljake:patch-1
kerneljake wants to merge 2 commits intoRedisLabs:masterfrom
kerneljake:patch-1
Conversation
Multiple testers have failed to use the GKE Quickstart because the preceding "Redis Enterprise Chart" section will not work for a first time user. Secondly, the namespace argument is not consistent in the examples.
ushachar
suggested changes
Jul 11, 2018
README.md
Outdated
| @@ -1,5 +1,14 @@ | |||
| # Redis Labs helm repository | |||
|
|
|||
| ## GKE quickstart | |||
There was a problem hiding this comment.
Rename to 'GKE and helm initialization'?
Contributor
There was a problem hiding this comment.
@kerneljake Please rename to Helm initialization on GKE,
| password=$(gcloud container clusters describe YOUR_SETUP_NAME --zone us-central1-a | grep password | cut -d":" -f 2 | tr -d " ") | ||
| kubectl --username=admin --password=$password apply -f rbac_tiller.yaml | ||
| helm init --service-account tiller | ||
| helm install --namespace redis -n 'redis-enterprise' ./redis-enterprise |
Contributor
There was a problem hiding this comment.
please delete this line - it shows up again in line 28
README.md
Outdated
| @@ -1,5 +1,14 @@ | |||
| # Redis Labs helm repository | |||
|
|
|||
| ## GKE quickstart | |||
Contributor
There was a problem hiding this comment.
@kerneljake Please rename to Helm initialization on GKE,
README.md
Outdated
| ## GKE quickstart | ||
|
|
||
| ```bash | ||
| password=$(gcloud container clusters describe YOUR_SETUP_NAME --zone us-central1-a | grep password | cut -d":" -f 2 | tr -d " ") |
Contributor
There was a problem hiding this comment.
" us-central1-a" can be changed to ZONE to be more generic
michalrabinowitch
approved these changes
Jul 12, 2018
Contributor
michalrabinowitch
left a comment
michalrabinowitch
left a comment
There was a problem hiding this comment.
when merging please squash and merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple testers have failed to use the GKE Quickstart because the preceding "Redis Enterprise Chart" section will not work for a first time user. Secondly, the namespace argument is not consistent in the examples.