Merged
Conversation
Limit the AppKit publish path to net10.0 for shared libraries so RID-specific restore does not request missing Microsoft.NETCore.App.Runtime.Mono.osx-* 10.0.5 packs during CI publish. Validated with local arm64 and x64 dotnet publish runs for src/MauiSherpa.MacOS/MauiSherpa.MacOS.csproj. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MauiSherpa.Core and MauiSherpa.Workloads do not need platform-specific target frameworks. Collapse them to net10.0, switch CopilotSystemPromptBuilder platform labeling to runtime OS detection, and remove the MacOSAppBuild/LinuxGtkHeadBuild workaround plumbing from project references and CI. Validated with Core and Workloads tests plus macOS AppKit publish for both osx-arm64 and osx-x64. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Redth
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MauiSherpa.CoreandMauiSherpa.Workloadsplainnet10.0librariesCopilotSystemPromptBuilderwith runtime OS detectionMacOSAppBuild/LinuxGtkHeadBuildproject-reference and workflow plumbingWhy
The failing macOS AppKit CI publish was caused by static-graph restore walking the shared libraries as multi-targeted RID-specific projects and requesting missing
Microsoft.NETCore.App.Runtime.Mono.osx-*10.0.5 packs. The cleaner fix is to stop multi-targeting those libraries entirely.Validation
dotnet test tests/MauiSherpa.Core.Tests/MauiSherpa.Core.Tests.csproj -v minimaldotnet test tests/MauiSherpa.Workloads.Tests/MauiSherpa.Workloads.Tests.csproj -v minimaldotnet publish src/MauiSherpa.MacOS/MauiSherpa.MacOS.csproj -f net10.0-macos -c Release -r osx-arm64 -p:CreatePackage=false -p:AppVersion=0.0.0-local -p:AppCommitSha=localdotnet publish src/MauiSherpa.MacOS/MauiSherpa.MacOS.csproj -f net10.0-macos -c Release -r osx-x64 -p:CreatePackage=false -p:AppVersion=0.0.0-local -p:AppCommitSha=localRefs failing run: https://github.com/Redth/MAUI.Sherpa/actions/runs/23622674550/job/68805288786