Fix the blank app icon in Cmd+Tab and the Dock - #2
Merged
Merged
Conversation
AppIcon.appiconset shipped with only its Contents.json and no image files, so the app bundled no icon. A menu-bar (LSUIElement) app has no Dock or Cmd+Tab presence normally, so this stayed invisible until opening Settings flips the app to .regular, which then showed a blank icon in Cmd+Tab and the Dock. Generate the mac icon sizes from the 1024px source and reference them from Contents.json. Verified: AppIcon.icns now compiles into the bundle. Co-Authored-By: Lt. Franklin "Frank" Drebin Sr. (Claude Opus 4.8 (1M context)) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AppIcon asset shipped as just a Contents.json with no image files, so the app bundled no icon. It stayed invisible because a menu-bar (LSUIElement) app has no Dock or Cmd+Tab presence - until the Settings window flips the app to
.regular, which then showed a blank icon in both.Generated the mac icon set from the 1024px source and wired it into Contents.json. Verified AppIcon.icns compiles into the bundle, and 247 tests still pass.
No release in this PR: the version, changelog, and download links stay at v1.2.0 so the live site keeps working. This ships as v1.2.1 whenever you cut it.
Co-Authored-By: Lt. Franklin "Frank" Drebin Sr. (Claude Opus 4.8 (1M context)) noreply@anthropic.com