feat(cortex-x): Open backup + tmp paths with wx flag in hooks-register and claude-md-aug - #24
Draft
github-actions[bot] wants to merge 1 commit into
Conversation
…r and claude-md-aug Open `bin/cortex-hooks-register.cjs` (lines 138 and 150) and `bin/cortex-claude-md-augment.cjs` (lines 139 and 153). At each `fs.writeFile` / `fs.copyFile` call that produces a tmp or backup file, add `flag: 'wx'` to the options object. The `wx` flag aborts the write if the target path already exists or is a symlink, providing defense-in-depth against TOCTOU symlink swaps. Target dir is user-owned so practical attack surface is low, but the fix is one option object change per call site. Add a fixture test per CJS that pre-creates a symlink at the expected backup path and asserts the apply step exits with a clear error rather than overwriting through the symlink. Steward-Action-Id: 01KVSEHHY41WZY8FREJ6MGJ6XJ Steward-Journal-Entry: ~/.cortex/journal/cortex-x/2026-06-23.jsonl Steward-Trigger: cron Steward-Recommendation-Source: cortex/recommendations.md#4-open-backup-tmp-paths-with-wx-flag-in Co-Authored-By: Steward <steward@cortex-x.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open
bin/cortex-hooks-register.cjs(lines 138 and 150) andbin/cortex-claude-md-augment.cjs(lines 139 and 153). At eachfs.writeFile/fs.copyFilecall that produces a tmp or backup file, addflag: 'wx'to the options object. Thewxflag aborts the write if the target path already exists or is a symlink, providing defense-in-depth against TOCTOU symlink swaps. Target dir is user-owned so practical attack surface is low, but the fix is one option object change per call site. Add a fixture test per CJS that pre-creates a symlink at the expected backup path and asserts the apply step exits with a clear error rather than overwriting through the symlink.Steward-Action-Id: 01KVSEHHY41WZY8FREJ6MGJ6XJ
Steward-Journal-Entry: ~/.cortex/journal/cortex-x/2026-06-23.jsonl
Steward-Trigger: cron
Steward-Recommendation-Source: cortex/recommendations.md#4-open-backup-tmp-paths-with-wx-flag-in
Co-Authored-By: Steward steward@cortex-x.local