Skip to content

Backport engine-side Julia SDK changes#244

Merged
comnik merged 1 commit intomainfrom
ncg-port-engine-patches
Apr 10, 2026
Merged

Backport engine-side Julia SDK changes#244
comnik merged 1 commit intomainfrom
ncg-port-engine-patches

Conversation

@comnik
Copy link
Copy Markdown
Collaborator

@comnik comnik commented Apr 10, 2026

Summary

Backports several engine-side changes to the Julia SDK's properties.jl and adds comprehensive test coverage:

  • read_lqp / read_bin (from RelationalAI/raicode#27597): Replaces the single read_transaction function with read_lqp (parses text .lqp files via the Parser) and read_bin (decodes binary protobuf files). This allows query_lqp on the engine side to dispatch based on file extension.

  • collect_demanded_relations (from RelationalAI/raicode#27172, RelationalAI/raicode#27613): Adds collect_demanded_relations(epoch) and _collect_read_ids! helpers that collect all relation IDs demanded by an epoch's reads (Demand, Output, Abort, Export). The Export handler dispatches on csv_config vs iceberg_config (incorporating the fix from #27613).

  • global_ids tests: Adds test coverage for all branches of global_ids (Def, Constraint, EDB, CSVData, IcebergData), which was previously untested.

Test plan

  • read_lqp: reads a .lqp file and produces a valid Transaction
  • read_bin: reads a .bin file and produces a valid Transaction
  • read_lqp and read_bin agree on all matching test file pairs
  • global_ids covers Def, Constraint, EDB, CSVData, IcebergData, and DeclarationData routing
  • collect_demanded_relations covers empty epochs, all read types, deduplication, CSV export columns, Iceberg export table_def, and empty export config
  • Full properties test suite passes (120 assertions across 12 test items)

🤖 Generated with Claude Code

@comnik comnik self-assigned this Apr 10, 2026
Copy link
Copy Markdown
Contributor

@hbarthels hbarthels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@comnik comnik merged commit d467c84 into main Apr 10, 2026
5 checks passed
@comnik comnik deleted the ncg-port-engine-patches branch April 10, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants