Skip to content

Support v2 CSV export in _collect_read_ids!. #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hbarthels merged 1 commit into from
Apr 13, 2026
Merged

Support v2 CSV export in _collect_read_ids!. #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions sdks/julia/LogicalQueryProtocol.jl/src/properties.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,23 @@ function _collect_read_ids!(ids::Set{LQPRelationId}, _export::Export)
config = _export.export_config
if config.name == :csv_config
csv_config = config[]::ExportCSVConfig
for column in csv_config.data_columns
!isnothing(column.column_data) && push!(ids, persistent_id(column.column_data))
if isempty(csv_config.data_columns)
# v2: data source is specified via csv_source
src = isnothing(csv_config.csv_source) ? nothing : csv_config.csv_source.csv_source
if !isnothing(src)
if src.name == :gnf_columns
for column in (src[]::ExportCSVColumns).columns
!isnothing(column.column_data) && push!(ids, persistent_id(column.column_data))
end
elseif src.name == :table_def
push!(ids, persistent_id(src[]::RelationId))
end
end
else
# v1: data source is specified via data_columns
for column in csv_config.data_columns
!isnothing(column.column_data) && push!(ids, persistent_id(column.column_data))
end
end
elseif config.name == :iceberg_config
iceberg_config = config[]::ExportIcebergConfig
Expand Down
Loading