Repository navigation
Fix Google Maps 'places_impl' loading error and upgrade UUID warning - #143
FrPellissier wants to merge 2 commits into
Conversation
- Replaced custom `useScript` logic with `@googlemaps/js-api-loader` to fix the `Could not load "places_impl"` Sentry bug and properly await `importLibrary` initialization. - Added `resolutions` to `package.json` to bump deeply-nested `uuid` dependencies to `^8.3.0` and resolve Webpack deprecation warnings. - Fixed flaky `updatedAt` date issues in message mocks that were causing Jest sorting failures. - Fixed implicit any type assertions and strictly typed API responses. Co-authored-by: FrPellissier <3436743+FrPellissier@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Updated `actions/cache@v2`, `actions/checkout@v2`, and `actions/setup-node@v2` to `@v4` in `.github/workflows/test.yml` since `v2` caches are deprecated and throw hard failures. - Migrated away from deprecated `set-output` syntax using `$GITHUB_OUTPUT`. - Downgraded `@googlemaps/js-api-loader` to `^1.16.8` to safely use the `Loader` class across SSR applications, directly invoking `loader.load()`. Co-authored-by: FrPellissier <3436743+FrPellissier@users.noreply.github.com>
This branch has not been deployed
1 participant
Fixes the critical Google Maps loading failure by implementing the modern API Loader library, resolves the
uuidversion deprecation warning, and ensures all TypeScript / Jest CI checks pass cleanly.PR created automatically by Jules for task 590271253941114342 started by @FrPellissier