Skip to content

Feat/ticket detaild#106

Merged
kubapoke merged 8 commits intodevelopfrom
feat/TicketDetaild
May 3, 2025
Merged

Feat/ticket detaild#106
kubapoke merged 8 commits intodevelopfrom
feat/TicketDetaild

Conversation

@staszkiet
Copy link
Copy Markdown
Member

No description provided.

Comment thread TickAPI/TickAPI/Events/Repositories/EventRepository.cs Outdated
Comment thread TickAPI/TickAPI/Events/Services/EventService.cs Outdated
Comment thread TickAPI/TickAPI/Tickets/Abstractions/ITicketRepository.cs Outdated
Comment thread TickAPI/TickAPI/Tickets/Abstractions/ITicketService.cs Outdated
Comment thread TickAPI/TickAPI/Tickets/Abstractions/ITicketService.cs Outdated
Comment thread TickAPI/TickAPI/Tickets/Repositories/TicketRepository.cs Outdated
Comment thread TickAPI/TickAPI/Tickets/Repositories/TicketRepository.cs Outdated
"for this user");
}

public async Task<Result<Ticket>> GetTicketByIdAsync(Guid id)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be wise to use name like GetTicketWithDetailsByIdAsync to state that we are including here other entities (Event, TicketType, etc) so if someone needs just a ticket they don't use this method but rather some simpler version without includes.

Comment thread TickAPI/TickAPI/Tickets/Services/TicketService.cs Outdated
Comment thread TickAPI/TickAPI/Tickets/Services/TicketService.cs Outdated
Comment thread TickAPI/TickAPI/Tickets/Services/TicketService.cs Outdated
Comment thread TickAPI/TickAPI/Tickets/Abstractions/ITicketRepository.cs Outdated
Comment thread TickAPI/TickAPI.Tests/Tickets/Services/TicketServiceTests.cs Outdated
Copy link
Copy Markdown
Member

@kubapoke kubapoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kubapoke kubapoke merged commit 16ca7dd into develop May 3, 2025
1 check passed
@kubapoke kubapoke deleted the feat/TicketDetaild branch May 3, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Endpoint for getting single ticket with all details [customer perspective]

3 participants