Add layered settings with a /settings overlay - #9
Open
azeemshaik025 wants to merge 1 commit into
Open
Conversation
- Resolve settings from defaults, global file, project file, then env, with a per-field fold so a project file setting one key does not reset the others - Add a /settings overlay to edit either scope live, showing where each value came from and whether editing it there would take effect - Reload on file change and rebind the model without a restart - Record mid-session model changes in the session log so a resumed session continues on the model it ended with - Add ReasoningEffort::Auto so "let the model decide" is representable, and bind unknown model ids instead of refusing them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings could only be changed by restarting with different
ALAN_*env vars, and there was no way to see what was in force. This adds a settings file plus a/settingsoverlay to edit it live./settingsedits either scope and marks where each value came from, and whether editing it there would actually take effectALAN_*parsing inmain.rs;ALAN_MODEL,ALAN_REASONING_EFFORTand the tool flags still work as the highest layerserdewas already a workspace dependency)Two things a reviewer might ask about.
bindnow synthesises aModelInfofor an id the catalog has not seen — without it only the model you launched with could ever bind, since the catalog holds exactly one entry. AndReasoningEffortgainedAuto, which is omitted from the wire, so "let the model decide" is distinct from explicitly sendingnone.Known gaps, deliberately left: a model id is not validated against the provider's catalog, and the overlay has nowhere to display a write error yet.