Skip to content

Conversation

@snoack
Copy link
Contributor

@snoack snoack commented Jan 6, 2024

This change is Reviewable

Copy link
Member

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for Hubkit, I'd like to see client usage before merging.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @snoack)


src/nodefire.ts line 251 at r1 (raw file):

  child<TSource extends Scope = EmptyScope>(
    path: string, scope?: TSource):
  NodeFire<TScope & TSource> {

Nit: line wrap.

Suggestion:

  child<TSource extends Scope = EmptyScope>(
    path: string, scope?: TSource
  ): NodeFire<TScope & TSource> {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants