Implement dark mode for unauthenticated Settings - #11
Open
anamhira47 wants to merge 3 commits into
Conversation
Remove forced light color scheme and make sweepInk, sweepMuted, and card stroke colors adapt to the system appearance so unauthenticated Settings remains readable in dark mode. Co-authored-by: Anam Hira <anam@revyl.ai>
Co-authored-by: Anam Hira <anam@revyl.ai>
Prefer .primary and .secondary in SettingsScreen and SignedOutPanel so labels stay readable when the system switches to dark appearance. Co-authored-by: Anam Hira <anam@revyl.ai>
|
Preview builds for
Validation
What we exercised We launched the app with the system Dark Mode appearance enabled. We verified that the bottom signed-out banner on the main map uses appropriate dark surfaces. Finally, we opened the unauthenticated Settings screen via the gear icon and confirmed that the background, card panels, and text labels render perfectly with dynamic dark-mode colors instead of being forced into light mode. Revyl debug · proof diagnostics (internal)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Enables system dark mode for SweepAlert and updates the unauthenticated Settings cluster so text and surfaces remain readable when the device uses a dark appearance.
Previously, dark mode was blocked in two places:
SweepAlertSwiftAppforced.preferredColorScheme(.light)Info.plistsetUIUserInterfaceStyletoLightThis PR removes both locks so the app follows the system appearance.
Changes
SweepAlertSwiftApp.swiftandInfo.plistsweepInk,sweepMuted, and card strokes using dynamicUIColorprovidersSettingsScreenandSignedOutPanel(.primary/.secondary) for the unauthenticated Account and Crew sectionsapps/ios-sweep-alert/.revyl/config.yaml)Device verification
Before (light mode — unauthenticated Settings):
After (dark appearance enabled on device):
systemGroupedBackground/systemBackgroundand semantic text colors for dark readabilityValidation notes:
revyl device instructionsuccessfully opened unauthenticated Settings on deviceTest plan