Add light mode for unauthenticated Settings screen - #9
Draft
anamhira47 wants to merge 1 commit into
Conversation
Introduce SettingsLightTheme with explicit light palette tokens and apply them when the user is signed out. Remove app-wide light mode forcing so Settings can opt into light appearance independently via preferredColorScheme. Co-authored-by: Anam Hira <anam@revyl.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a dedicated light mode for the Settings (unauthenticated) screen in SweepAlert Swift.
SettingsLightThemewith explicit light palette tokens (grouped background, white cards, ink/muted text, separators).SettingsScreento use the light theme when the user is signed out..preferredColorScheme(.light)only for the signed-out Settings experience.SweepAlertSwiftAppandInfo.plistso light appearance is scoped to Settings when signed out.Target screen
Settings → signed out (Account + Crew sections with Log in button).
Before
Baseline build showing the in-app Settings screen while signed out.
After
Rebuild with scoped light theme: light gray grouped background, white rounded cards, dark text, blue Log in CTA, and locked Crew section.
Device verification
settings-screen,login-buttonaccessibility identifiers).Automated
revyl device instructionverification was blocked by an in-flight worker step (HTTP 409), but screenshot evidence confirms the expected UI.Files changed
apps/ios-sweep-alert/SweepAlertSwift/SettingsLightTheme.swift(new)apps/ios-sweep-alert/SweepAlertSwift/ContentView.swiftapps/ios-sweep-alert/SweepAlertSwift/SweepAlertSwiftApp.swiftapps/ios-sweep-alert/SweepAlertSwift/Info.plistapps/ios-sweep-alert/SweepAlertSwift.xcodeproj/project.pbxproj