Clean up source builds and native registration - #141
Open
xjsun1221 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This PR addresses three source-build and native-interface issues:
Rfast.dll, andsymbols.rdsunder
src/. A direct installation from the GitHub archive can thereforeskip compilation and reuse a DLL built against a different TBB ABI.
cts_rf.cppandg2t.hdefine different global classes with the sameTestResultname, violating the C++ one-definition rule.init.cregistration, but alsoretains stale
Rcpp::exportattributes. RunningcompileAttributes()cangenerate duplicate
bhattacharyyawrappers and unregistered_Rfast_*entry points.
Change
CtsTestResult.hand-written registration and public R API.
Validation
LoadLibraryfailure after make reportedNothing to be done for 'all'for the unmodified GitHub archive.Rcpp::compileAttributes()completes without warnings and does not createconflicting wrapper files.
pc.skel(),g2Test(),coeff(),eachcol.apply(), andvecdist().R CMD check --no-manualcompleted with 0 errors. Its only warning was thatlocally installed dependencies were built under newer R 4.5 patch releases;
the unavailable suggested package
philentropywas not forced.