Fix crash launching the Authress Custom Tab from Application context - #6
Merged
Merged
Conversation
AuthressLoginClient is built once in AppContainer with the Application context, never an Activity, so CustomTabsIntent.launchUrl needs FLAG_ACTIVITY_NEW_TASK set explicitly on its intent — without it, starting the activity throws. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XRMBgZXVCEVwBuBWapy5J7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Calling startActivity() from outside of an Activity context requires the FLAG_ACTIVITY_NEW_TASK flag.AuthressLoginClientis built once inAppContainerwith the Application context (EmailApp.onCreate()→AppContainer(this)), never an Activity.CustomTabsIntent.launchUrl()doesn't addFLAG_ACTIVITY_NEW_TASKitself, so starting the Custom Tab activity from that non-Activity context throws.CustomTabsIntent.Builder().build().launchUrl(...)call sites (authenticate()andlinkIdentity()) into a sharedlaunchAuthenticationUrl()helper that setsFLAG_ACTIVITY_NEW_TASKon the intent before launching.Test plan
gradle compileDebugKotlinwas not re-verified end-to-end here🤖 Generated with Claude Code
https://claude.ai/code/session_01XRMBgZXVCEVwBuBWapy5J7
Generated by Claude Code