Show sign-in progress step by step instead of one indefinite spinner - #7
Merged
Merged
Conversation
The login screen only ever showed a spinner from "tapped Continue" to "mailbox loaded", with no feedback if any step along the way stalled or failed silently — completeAuthenticationRequest's Result was discarded in MainActivity, so a failure there just left the spinner running forever. AuthressLoginClient now exposes authStatus (Idle/OpeningBrowser/ AwaitingRedirect/CompletingSignIn) and authError, updated at every transition and on every failure path in authenticate() and completeAuthenticationRequest(). LoginScreen renders these as a checklist (opening the sign-in page, waiting on the browser, completing sign-in, loading the mailbox) with the active step spinning and completed ones checked off, surfaces the failure message when one occurs, and — if a step runs long — shows a "this is taking longer than expected" hint with a Try again action instead of leaving the user staring at a bare spinner. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XRMBgZXVCEVwBuBWapy5J7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MainActivityalso fire-and-forgetscompleteAuthenticationRequest'sResult, so a failure there previously left the spinner running forever with nothing surfaced to the user.AuthressLoginClientnow exposesauthStatus(Idle/OpeningBrowser/AwaitingRedirect/CompletingSignIn) andauthErrorstate flows, updated at every transition and on every failure path inauthenticate()andcompleteAuthenticationRequest().LoginScreenrenders these as an ordered checklist — opening the sign-in page, waiting on the browser, completing sign-in, loading the mailbox — with the active step spinning, completed steps checked off, and the failure message (if any) shown directly instead of an indefinite spin.Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01XRMBgZXVCEVwBuBWapy5J7
Generated by Claude Code