chore(qobuz): remove dead QobuzDownloadService (orphaned, unreferenced)#313
Open
RicherTunes wants to merge 1 commit into
Open
chore(qobuz): remove dead QobuzDownloadService (orphaned, unreferenced)#313RicherTunes wants to merge 1 commit into
RicherTunes wants to merge 1 commit into
Conversation
QobuzDownloadService (src/Core, 232 lines) is dead code: a plain class (no interface, not a Lidarr provider) that nothing instantiates, injects, or registers. Verified repo-wide — the only references were two XML doc-comments in QobuzCLI mentioning it by name; the CLI actually uses its own CliDownloadService. No DI registration, no tests, no callers. The live download path is QobuzTrackDownloader + AudioFileDownloader (impl of IAudioFileDownloader, auto-wired by Lidarr convention DI and exercised by QobuzTrackDownloaderTests) — those stay. Updated the two now-stale doc-comments to not reference the removed class. Verify: Qobuzarr.csproj builds 0 errors; 491 download-area unit tests pass. (The single failure is the Docker E2E Plugin_Loads_AppearsInDownloadClientSchema — environmental: needs the merged DLL deployed to the container, unaffected by removing an unreferenced class.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-submission of a fix that got stranded on a merged branch (its original branch's PR #295 was already merged when the commit landed, so it never reached main + no CI ran).
What
Removes
src/Core/QobuzDownloadService.cs(232 lines) — a plain class (no interface, not a Lidarr provider) with zero instantiation / DI / tests / callers. The only references were two XML doc-comments in QobuzCLI; the CLI uses its ownCliDownloadService. The live download path (QobuzTrackDownloader+AudioFileDownloader) is untouched. This also resolves the resume-416 dead-dup (the dead class held the duplicate resume logic).Verify
Builds 0-error; 491 download-area unit tests pass (verified locally).
🤖 Generated with Claude Code