fix(bluetooth): rediscover remembered heart-rate monitors - #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Remove the HR-specific advertisement-discovery opt-out. Use the existing shared discovery lifecycle alongside bounded direct GATT retries, retaining fallback when watching fails or produces no events.
Live hardware evidence
A remembered TRACKR HR repeatedly rejected GATT connections in 1–2 ms with NetworkError: Bluetooth Device is no longer in range. Enabling advertisement watching for that same device, without refreshing or re-pairing, exposed its broadcasts and allowed the unchanged retry loop to connect. The dashboard showed live heart rate and battery status; it remained connected after diagnostic instrumentation was removed.
Verification