feat: compare bulk download formats in a modal - #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the bulk download format dropdown with a Download all modal containing a seven-row TCX/FIT comparison, the TCX round-trip recommendation, and explicit Download TCX, Download FIT, and Cancel actions. Removes obsolete remembered bulk-format preference while preserving single-ride export controls. Adds modal preparation errors, duplicate-download guards, focus restoration, keyboard navigation and responsive scrolling. Updates README. Verified actual TCX and FIT ZIP downloads in isolated Chrome and restored both saved rides from each archive; checked all Sessions tabs, cancellation, Escape/backdrop dismissal, error recovery, keyboard focus and mobile scrolling. Full local CI passed immediately before push: 404 tests, Biome, Tailwind diagnostics, TypeScript, and production build.