fix: use fixed agent ID for hand agents based on hand_id#520
Open
houko wants to merge 3 commits intoRightNow-AI:mainfrom
Open
fix: use fixed agent ID for hand agents based on hand_id#520houko wants to merge 3 commits intoRightNow-AI:mainfrom
houko wants to merge 3 commits intoRightNow-AI:mainfrom
Conversation
This ensures triggers and cron jobs continue to work after daemon restart, as hand agents now have stable IDs instead of generating a new UUID each time. Changes: - Add AgentId::from_string() method for deterministic ID generation - Modify spawn_agent_with_parent() to accept optional fixed_id - Use hand_id-based fixed ID in activate_hand() See: RightNow-AI#519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This ensures triggers and cron jobs continue to work after daemon restart, as hand agents now have stable IDs instead of generating a new UUID each time.
Changes
Add
AgentId::from_string()method incrates/openfang-types/src/agent.rsModify
spawn_agent_with_parent()incrates/openfang-kernel/src/kernel.rsfixed_idparameterUse fixed ID in
activate_hand()AgentId::from_string(hand_id)for stable identityWhy this is better than reassign
Instead of adding reassign logic (like cron jobs have), we make hand agent IDs stable from the start. This is cleaner and doesn't require maintaining a mapping table.
See: #519